Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: QoL for port work, more mips re-enablement #21073

Merged
merged 12 commits into from
Aug 16, 2024

Conversation

alexrp
Copy link
Member

@alexrp alexrp commented Aug 14, 2024

  • Improve getExternalExecutor() to handle a few more architectures/ABIs.
  • Disable lowering to f16/f128 for a few more LLVM targets that are known to be problematic.
  • Re-enable mips(el)-linux-gnueabihf tests since unable to build mipsel glibc: fatal error: 'entry.h' file not found #4927 appears to be fixed.
    • But note the ongoing discussion on Discord about MIPS run times on CI.
  • Add a test-modules step for specifically running the per-target tests and nothing else.
  • Add a -Dtest-target-filter option for filtering which targets the module tests are run for.
  • Add a -Dtest-slow-targets option (and use it in CI) that currently covers all MIPS target tests.
    • These are now off by default since they take too long to run for local development.

alexrp added 12 commits August 13, 2024 23:30
This is precisely the kind of use case it was added for.
…rget triple.

This is useful during porting work where you're not interested in running all
targets all the time while iterating on changes.
… it.

The idea is that these tests are just too slow to include by default on a
contributor's local machine. If they want to run these, they need to opt in.
…sts.

This is useful during porting work where you're mainly concerned with tests that
e.g. run under QEMU. Combine with the new -Dtest-target-filter for an even more
streamlined workflow.
@alexrp alexrp changed the title test: QoL for port work, more mips re-enablement, arm v8 -> v7 test: QoL for port work, more mips re-enablement Aug 14, 2024
@alexrp
Copy link
Member Author

alexrp commented Aug 14, 2024

Dropping the arm v8a -> v7a change in this; it results in a bunch of f16-related test failures that look like LLVM miscompilations, and lowering f16 to i16 with soft float libcalls doesn't work because compiler-rt expects EABI names (__aeabi_d2h vs __truncdfhf2). Need to investigate this more.

@andrewrk andrewrk merged commit 11176d2 into ziglang:master Aug 16, 2024
10 checks passed
@alexrp alexrp deleted the test-changes branch August 16, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants