Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disallow non scalar sentinels in array types #22473

Merged
merged 1 commit into from
Jan 13, 2025
Merged

disallow non scalar sentinels in array types #22473

merged 1 commit into from
Jan 13, 2025

Conversation

xdBronch
Copy link
Contributor

closes #22472

@mlugg
Copy link
Member

mlugg commented Jan 12, 2025

Would you also be able to add this check to the .pointer and .array cases in zirReify (corresponding to @Type), and add corresponding tests? (I'd personally just combine all these tests into one non_scalar_sentinel.zig.)

@xdBronch
Copy link
Contributor Author

oh sure, didnt realize that was a separate code path

mlugg
mlugg reviewed Jan 12, 2025
View reviewed changes
src/Sema.zig Show resolved Hide resolved
src/Sema.zig Show resolved Hide resolved
@mlugg mlugg enabled auto-merge (rebase) January 12, 2025 23:54
@mlugg mlugg disabled auto-merge January 12, 2025 23:54
@mlugg mlugg enabled auto-merge (squash) January 12, 2025 23:54
@mlugg mlugg merged commit fb43e91 into ziglang:master Jan 13, 2025
10 checks passed
@xdBronch xdBronch deleted the push-ykprszstmnqu branch January 13, 2025 05:29
Fri3dNstuff pushed a commit to Fri3dNstuff/zig that referenced this pull request Jan 27, 2025
@xdBronch @Fri3dNstuff
Sema: disallow non scalar sentinels in array types and reified types (z…
945c0b3 
…iglang#22473)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlugg mlugg mlugg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

non scalar sentinels allowed in array types
2 participants
@xdBronch @mlugg