Add Giex GX04 Soil Sensor #3412
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3412 +/- ##
==========================================
+ Coverage 88.72% 88.74% +0.01%
==========================================
Files 306 306
Lines 9813 9830 +17
==========================================
+ Hits 8707 8724 +17
Misses 1106 1106 ☔ View full report in Codecov by Sentry. |
prairiesnpr
force-pushed
the
giex-soil-04
branch
from
dd3e634
to
b0a42ab
Compare
TheJulianJES
added
new quirk
dmulcahey
approved these changes
Oct 11, 2024
Comment on lines
+511
to
+517
| attributes = TuyaMCUCluster.attributes.copy() | ||
| attributes.update( | ||
| { | ||
| BATTERY_STAT_ATTR: ("battery_status", GiexBatteryStatus, True), | ||
| TEMP_SW_ATTR: ("temp_cf_switch", GiexTempEnum, True), | ||
| } | ||
| ) |
There was a problem hiding this comment.
Ideally, we'd use the new AttributeDefs, but I do see that the TuyaMCUCluster isn't converted yet. Are there any attributes on that cluster?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add Giex GX04 Soil Moisture Probe
Additional information
Checklist
pre-commitchecks pass / the code has been formatted using Black