Allow translation key even when device class is overridden #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbancroft
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since zigpy/zigpy#1474 was merged, translation_key and/or fallback_name is a mandatory field for a V2 quirk entity, and the restriction of not being able to set them when device class is explictly set has been dropped.
From what I can tell, there isn't a good reason for this restriction, and the device class alone isn't a replacement for not having a translation key (such as the case when a device has two sensors of the same device class and you need a way to differentiate between them). If my understanding is flawed here, please let me know and we can drop this PR.
On the ZHA side, the check for device is still present. This pull request is for its removal.