-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for EFFECT_OFF #99
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #99 +/- ##
==========================================
+ Coverage 96.45% 96.49% +0.04%
==========================================
Files 61 61
Lines 9336 9337 +1
==========================================
+ Hits 9005 9010 +5
+ Misses 331 327 -4 ☔ View full report in Codecov by Sentry. |
c8958f3
to
d8ce6c0
Compare
I've rebased the PR to fix the conflicts and addressed the comments I just made above. There's some more context in those comments on why the changes are needed IMO. |
This reverts commit aa870ef.
Changing any other attributes always turns off the effect at the moment, so we need to pass that to the members.
7fd58a4
to
225fa45
Compare
I think this PR should be ready now. The missing coverage is on existing lines, something to improve in the future. Also discovered an existing (long-standing) issue when turning off effects via changing the color, but it's unrelated to this PR. Filed #210. Also something to be fixed in the future. The effect code on/off should be cleaned up a bit with it. Looks like nobody reported this before. |
Fixes: #98