Resolve return type of orelse with block on RHS (with return)
#2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7phs
force-pushed
the
resolve-orelse-with-return
branch
2 times, most recently
from
3cd6dfa to
f294431
Compare
Techatrix
requested changes
Nov 17, 2024
7phs
force-pushed
the
resolve-orelse-with-return
branch
from
f294431 to
7df0b48
Compare
Techatrix
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes completion issues for cases with
orelseandreturn(or block) expressions.Currently, only the right side of an
orelseexpression is analyzed, which lacks type information in cases whereorelseis used with block (returninside). This PR addresses the issue by ensuring that the left side of the expression is also analyzed.This fix resolves issue #1989 .