Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the wrong search return value in the Redis vector store. #452

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

SimFG
Copy link
Collaborator

@SimFG SimFG commented Jun 28, 2023

issue: #451

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #452 (6f3ddf5) into dev (66a3a1b) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #452      +/-   ##
==========================================
+ Coverage   93.82%   93.97%   +0.14%     
==========================================
  Files          90       90              
  Lines        3335     3335              
==========================================
+ Hits         3129     3134       +5     
+ Misses        206      201       -5     
Impacted Files Coverage Δ
gptcache/utils/dependency_control.py 100.00% <ø> (ø)
gptcache/manager/vector_data/redis_vectorstore.py 98.07% <100.00%> (+5.76%) ⬆️

... and 2 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 28, 2023
@SimFG SimFG merged commit e43160f into zilliztech:dev Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants