Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manually install openblas code in scripts #352

Closed
wants to merge 2 commits into from

Conversation

chasingegg
Copy link
Collaborator

/kind improvement

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexanderguzhva
Copy link
Collaborator

/lgtm

Signed-off-by: chasingegg <[email protected]>
@sre-ci-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@sre-ci-robot sre-ci-robot removed the lgtm label Jan 22, 2024
@alexanderguzhva
Copy link
Collaborator

@chasingegg are unit tests good?

@liliu-z
Copy link
Collaborator

liliu-z commented Mar 4, 2024

Some comments on the install_deps changes:

  1. Ensure idempotence
  2. Remove redundance
  3. Fail fast

Thx for these changes

@mergify mergify bot added needs-dco and removed dco-passed labels Mar 6, 2024
@chasingegg chasingegg closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants