Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix diskann async cache generation #373

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

foxspy
Copy link
Collaborator

@foxspy foxspy commented Feb 1, 2024

issue: #372

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

mergify bot commented Feb 1, 2024

@foxspy 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@foxspy foxspy force-pushed the fix_async_cache branch 3 times, most recently from 8bf2691 to 3db6a5f Compare February 4, 2024 07:56
@mergify mergify bot added the ci-passed label Feb 4, 2024
@foxspy
Copy link
Collaborator Author

foxspy commented Feb 4, 2024

/kind improvement

@mergify mergify bot removed the ci-passed label Feb 22, 2024
@foxspy
Copy link
Collaborator Author

foxspy commented Feb 22, 2024

/run-e2e

@alexanderguzhva
Copy link
Collaborator

/lgtm

@sre-ci-robot sre-ci-robot merged commit d4dd8fe into zilliztech:main Feb 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants