fix:miss wait thread tasks finish in diskann. #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cqy123456 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cqy123456 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
|
@cqy123456 e2e jenkins job failed, comment |
1 similar comment
|
@cqy123456 e2e jenkins job failed, comment |
cqy123456
force-pushed
the
2.2-diskann-miss-wait
branch
from
e2f6ba2 to
532591d
Compare
|
@cqy123456 e2e jenkins job failed, comment |
Signed-off-by: cqy123456 <[email protected]>
cqy123456
force-pushed
the
2.2-diskann-miss-wait
branch
from
532591d to
6fbff67
Compare
|
/lgtm |
foxspy
added a commit
that referenced
this pull request
Feb 29, 2024
* Remove omp (#276) Signed-off-by: Yudong Cai <[email protected]> * [cherry-pick]Pip3 install in requirements.txt order (#303) Signed-off-by: cqy123456 <[email protected]> * Cherry-pick #294 #298 from main (#300) Signed-off-by: Yudong Cai <[email protected]> * Deprecate Invalid config checking (#304) Signed-off-by: Li Liu <[email protected]> * Fix scann range search (#316) Signed-off-by: chasingegg <[email protected]> * Upgrade conan to 1.61.0 (#182) (#347) Signed-off-by: Enwei Jiao <[email protected]> Co-authored-by: Enwei Jiao <[email protected]> * raft hasrawdata return false Signed-off-by: yusheng.ma <[email protected]> * switch knowhere-test branch (#384) Signed-off-by: cqy123456 <[email protected]> * Ensure topk results for IVF_FLAT_CC (#353) (#383) Signed-off-by: chasingegg <[email protected]> * make sure we rethrow exceptions in async tasks: make sure we do not crash due to uncaught exceptions when we called folly::Future::wait but not trying to get the values; use folly::collect to simplify code (#382) Signed-off-by: Buqian Zheng <[email protected]> * [2.2 fix] wrap IVF index train/build calls in lambdas passed to knowhere thread pool, so OMP threads spawned will have low nice values (#379) Signed-off-by: Buqian Zheng <[email protected]> * fix diskann async cache generation (#377) Signed-off-by: xianliang <[email protected]> * fix:miss wait thread tasks finish in diskann. (#380) Signed-off-by: cqy123456 <[email protected]> * Shuffle ids for building hnsw index (#322) (#381) Signed-off-by: chasingegg <[email protected]> * sync knowherer 2.2.4 Signed-off-by: xianliang <[email protected]> --------- Signed-off-by: Yudong Cai <[email protected]> Signed-off-by: cqy123456 <[email protected]> Signed-off-by: Li Liu <[email protected]> Signed-off-by: chasingegg <[email protected]> Signed-off-by: Enwei Jiao <[email protected]> Signed-off-by: yusheng.ma <[email protected]> Signed-off-by: Buqian Zheng <[email protected]> Signed-off-by: xianliang <[email protected]> Co-authored-by: Cai Yudong <[email protected]> Co-authored-by: cqy123456 <[email protected]> Co-authored-by: liliu-z <[email protected]> Co-authored-by: Gao <[email protected]> Co-authored-by: Enwei Jiao <[email protected]> Co-authored-by: yusheng.ma <[email protected]> Co-authored-by: Buqian Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #128
/kind improvement
cherry pick from master pr: #357 and c4c6663