Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pick: clear futures when all task finished #386

Merged
merged 1 commit into from
Feb 18, 2024
Merged

pick: clear futures when all task finished #386

merged 1 commit into from
Feb 18, 2024

Conversation

foxspy
Copy link
Collaborator

@foxspy foxspy commented Feb 18, 2024

issue: #385
related: #387

Signed-off-by: xianliang <[email protected]>
Copy link

mergify bot commented Feb 18, 2024

@foxspy 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@foxspy
Copy link
Collaborator Author

foxspy commented Feb 18, 2024

/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug This PR is a bug fix label Feb 18, 2024
@foxspy foxspy changed the title fix: clear futures when all task finished pick: clear futures when all task finished Feb 18, 2024
@liliu-z
Copy link
Collaborator

liliu-z commented Feb 18, 2024

/lgtm

@liliu-z
Copy link
Collaborator

liliu-z commented Feb 18, 2024

/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxspy, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yellow-shine
Copy link
Collaborator

/run-e2e

Copy link

mergify bot commented Feb 18, 2024

@foxspy e2e jenkins job failed, comment /run-e2e can trigger the job again.

@foxspy
Copy link
Collaborator Author

foxspy commented Feb 18, 2024

/run-e2e

@liliu-z liliu-z merged commit 3d7ac59 into 2.2 Feb 18, 2024
12 of 14 checks passed
@liliu-z liliu-z deleted the fix_future branch February 18, 2024 09:23
foxspy added a commit that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants