Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

milvus default to 2.4.19, supports imagePullSecrets for operator #226

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

haorenfsa
Copy link
Collaborator

No description provided.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.70%. Comparing base (d7a4a66) to head (6b9d4da).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage   80.70%   80.70%           
=======================================
  Files          56       56           
  Lines        6234     6234           
=======================================
  Hits         5031     5031           
  Misses       1014     1014           
  Partials      189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haorenfsa haorenfsa force-pushed the pull-secret branch 2 times, most recently from 1cb3e92 to 374573e Compare December 26, 2024 11:24
@haorenfsa haorenfsa changed the title supports image pull secrets milvus default to 2.4.18, supports image pull secrets Dec 26, 2024
@haorenfsa haorenfsa changed the title milvus default to 2.4.18, supports image pull secrets milvus default to 2.4.19, supports imagePullSecrets for operator Dec 27, 2024
@haorenfsa haorenfsa added the lgtm looks good to merge label Jan 3, 2025
@haorenfsa haorenfsa merged commit c6f0718 into zilliztech:main Jan 3, 2025
15 of 16 checks passed
@haorenfsa haorenfsa deleted the pull-secret branch January 3, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants