Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

milvus default to 2.5.4, update milvus-helm values #247

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

haorenfsa
Copy link
Collaborator

use milvus-helm values for pulsar3
bump version

/cc @LoveEachDay

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 68.48%. Comparing base (797f078) to head (67b84d7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/helm/values/values.go 0.00% 7 Missing ⚠️
pkg/controllers/dependencies.go 0.00% 2 Missing ⚠️
pkg/helm/helm.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
- Coverage   68.52%   68.48%   -0.05%     
==========================================
  Files          89       89              
  Lines        7473     7478       +5     
==========================================
  Hits         5121     5121              
- Misses       2157     2162       +5     
  Partials      195      195              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@LoveEachDay LoveEachDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm looks good to merge label Jan 23, 2025
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa, LoveEachDay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LoveEachDay,haorenfsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot removed the lgtm looks good to merge label Jan 23, 2025
@sre-ci-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

use milvus-helm values for pulsar3
bump version

Signed-off-by: haorenfsa <[email protected]>
@haorenfsa haorenfsa merged commit 7e08a8a into zilliztech:main Jan 23, 2025
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants