🥗🧹🥔✨ Marketplace: Show DeliveryArea in Order::EmailReceiptComponent
#1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zspencer
added
✨ feature
zspencer
requested review from
anaulin,
KellyAH and
a team
and removed request for
anaulin
…ent` - #1325 - #1324 - #1326 I didn't use the `marketplace_order, :full` factory outside of the `Order::PlacedMailerPreview` and `Order::ReceivedMailerPreview`; and apparently had flubbed the implementation; so that was not working... So I fixed it and used it in the `Order::EmailReceiptComponent` spec to test the `Order#delivery_area` I also noticed we didn't wire in associations between the `Marketplace::DeliveryArea` into the `Marketplace::Cart` and `Marketplace::Order` so I added some specs for those.
zspencer
force-pushed
the
marketplace/deliery/include-area-in-receipt
branch
from
123f169 to
48b23ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marketplace:Delivery #1325Marketplace: Selling 🥡Products #1324Marketplace: Buying 🥡Products #1326I didn't use the
marketplace_order, :fullfactory outside of theOrder::PlacedMailerPreviewandOrder::ReceivedMailerPreview; and apparently had flubbed the implementation; so that was not working...So I fixed it and used it in the
Order::EmailReceiptComponentspec to test theOrder#delivery_areaI also noticed we didn't wire in associations between the
Marketplace::DeliveryAreainto theMarketplace::CartandMarketplace::Orderso I added some specs for those.