🥔✨ Marketplace: Encrypt and Store Square Access Token
#1731
Conversation
zspencer
changed the title
Marketplacae: Encrypt and Store Square Access Token
zspencer
changed the title
Marketplacae: Encrypt and Store Square Access TokenMarketplace: Encrypt and Store Square Access Token
There was a problem hiding this comment.
This looks great! I did some digging and figured out why it was not working.
The TL/DR is that RankedModel uses Furniture.select(:id, :room_id, :slot) under the covers at some point; which retrieves only those three attributes.
By adding an if has_attribute?("secrets_ciphertext") we skip setting the default in cass where the secrets are not loaded.
…ext` isn't loaded (#1734)
|
Thanks for the assist @zspencer. Whew. I'm now more well-read on Ranked model, too. It's gotta be this line in the gem: https://github.com/brendon/ranked-model/blob/f9145d42041ed7186a893315350f01f87d39c76b/lib/ranked-model/ranker.rb#L276. I haven't traced beyond that. |
| # The `RankedModel` gem uses | ||
| # [`ActiveRecord::QueryMethods.select`](https://api.rubyonrails.org/classes/ActiveRecord/QueryMethods.html#method-i-select) | ||
| # to do some stuff (Validation?) under the covers while keeping memory usage light... Which is good! | ||
| # But it also means that we don't have the ciphertext! | ||
| # So we can't set the secrets in that case (nor would we want to) | ||
| self.secrets ||= {} if has_attribute?("secrets_ciphertext") |
There was a problem hiding this comment.
@zspencer Makes me think this will not be the last time we try to access data on models returned ranked queries with surprising results 🤣
Gizmo: Stores encryptedsecrets#1735Marketplace:SellerreceivesOrderin theirSquarePoint of Sale #1500I borrowed this pattern for storing encrypted data from
Utility, and I think it works well for Furniture-level private keys as well. In order not to conflict with the more generalsettingsattribute, I opted forsecrets.