Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌸 Themes/ Mobile: Eliminate top navigation #1859

Merged
merged 2 commits into from
Oct 5, 2023
Merged

🌸 Themes/ Mobile: Eliminate top navigation #1859

merged 2 commits into from
Oct 5, 2023

Conversation

zspencer
Copy link
Member

@zspencer zspencer commented Sep 30, 2023 •
edited
Loading

The top navigation is a bit excessive, especially on mobile.

This brings the UI to a much cleaner place; with breadcrumbs and sign in / out only on the bottom of the page.

After

Screenshot 2023-10-04 at 17-34-42 Convene - The Oakland Community Food Network

Before

Screenshot 2023-09-30 at 16-18-18 Convene - Zee's Space

@zspencer zspencer force-pushed the piikup/get-rid-of-top-nav branch 2 times, most recently from cb73bcb to 77bb5fe Compare September 30, 2023 23:17
@zspencer zspencer changed the title 🌸 Eliminate the top navigation 🌸 Themes: Eliminate top navigation Oct 1, 2023
@zspencer zspencer changed the title 🌸 Themes: Eliminate top navigation 🌸 Themes/ Mobile: Eliminate top navigation Oct 1, 2023
@anaulin
Copy link
Member

anaulin commented Oct 2, 2023

I agree that the current setup with Breadcrumbs and "Your account" and "Sign out" is a bit much ("Sign out" should be an option in the "Your Account" menu, and it should show your email address or name, instead of "Your Account"), but I think we need to replace it with some minimal framing or title for what the user is seeing. Otherwise it is not clear what am I looking at, it doesn't say "Marketplace" anywhere clearly, and it doesn't say "Piikup", I'm just dropped into "choose your delivery address", without confirmation of which site I'm on.

Showing the "room" name in the header was serving a bit of this purpose, because that way you can land on a page and see e.g. "Crumble & Whisk" at the top, but maybe we should instead have a header on the Gizmo itself, so it would say "Crumble & Whisk Marketplace" at the top (and maybe the content can be configurable).

@zspencer
Copy link
Member Author

zspencer commented Oct 2, 2023 •
edited
Loading

It is not clear what am I looking at, it doesn't say "Marketplace" anywhere clearly, and it doesn't say "Piikup", I'm just dropped into "choose your delivery address", without confirmation of which site I'm on.

Showing the "room" name in the header was serving a bit of this purpose, because that way you can land on a page and see e.g. "Crumble & Whisk" at the top, but maybe we should instead have a header on the Gizmo itself, so it would say "Crumble & Whisk Marketplace" at the top (and maybe the content can be configurable).

I like the idea of having the Marketplace include the name of both the Space and the Room (i.e. Shop Crumble & Whisk on the Piikup Marketplace) and we could make that configurable!

@zspencer
🌸 Eliminate the top navigation
6c65617 
- #832
- #621

The top navigation is a bit excessive. This brings the UI to a much
cleaner place; with breadcrumbs and sign in / out only  on the bottom
of the page.
@zspencer zspencer force-pushed the piikup/get-rid-of-top-nav branch from 77bffe1 to 6c65617 Compare October 5, 2023 00:21
@zspencer zspencer force-pushed the piikup/get-rid-of-top-nav branch from ff9b765 to f1decf6 Compare October 5, 2023 00:34
@zspencer
Copy link
Member Author

zspencer commented Oct 5, 2023

@anaulin how do you like it now? I put in a header on the Marketplace; which I think it wanted anyway; and that should better ground people so they know where they're at.

@zspencer zspencer requested review from a team October 5, 2023 00:37
anaulin
anaulin approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@anaulin anaulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@zspencer zspencer merged commit d24ec72 into main Oct 5, 2023
@zspencer zspencer deleted the piikup/get-rid-of-top-nav branch October 5, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anaulin anaulin anaulin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zspencer @anaulin