Marketplace 🛒: Member may add Products to Marketplace #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sadie Jay <[email protected]> Co-authored-by: Zee <[email protected]>
Co-authored-by: Sadie <[email protected]> Co-authored-by: Zee <[email protected]>
anaulin
force-pushed
the
ensemble/marketplace-furniture
branch
from
ef86f5e to
708f36a
Compare
…ler. Co-authored-by: Sadie <[email protected]> Co-authored-by: Zee <[email protected]>
This starts to shift our Furniture and Item system away from an inheritance oriented rails-adjacent structure to a more Rails-forward structure. Furniture now places it's routes against the *room*, which allows it to support either Singleton-type Resource routes, or more traditional Resources routes. Further, it brings the `Placeable` interface a bit closer to ActiveRecord; which should reduce pain-points as we unwind the current overly-restrictive and complex Furniture/Item design. * Marketplace: Products are shown! * Use correct parameter name in request spec Rails assumes that your parameter names will match the namespace of the model. For example, a `Marketplace::Product#name` Rails will make HTTP Params of `marketplace_product[name]`, I had previously assumed it would name them `product[name]` because I thought it would discard the stuff before the `::`. Co-authored-by: Neer Thapa <[email protected]> * Rename from `routing_context` to `router` @anaulin had suggested that `routing_context` was confusing; and I agree. It's just the router! So let's name it that way! Co-authored-by: Neer Thapa <[email protected]> * All `Placeable` now implement `to_partial_path` Co-authored-by: Neer Thapa <[email protected]> Co-authored-by: Zee Spencer <[email protected]> Co-authored-by: Neer Thapa <[email protected]>
Co-authored-by: Neer Thapa <[email protected]>
Co-authored-by: Neer Thapa <[email protected]>
Co-authored-by: Neer Thapa <[email protected]>
This makes the user experience for adding a product even tighter; by hiding the Product form until the Distributor is adding a new product. Once they do, we replace the entire marketplace with the New Product form; and upon successful create, we replace the entire marketplace with the full Marketplace view! Co-authored-by: Neer Thapa <[email protected]>
Still need to figure out how to redirect to furniture Co-authored-by: Kelly <[email protected]> Co-authored-by: Zee <[email protected]> Co-authored-by: Ana <[email protected]>
…improve-ui Marketplace: Improve the UI
Validate that `Marketplace::Product` belongs to a space Co-authored-by: Kelly <[email protected]> Co-authored-by: Zee <[email protected]> Co-authored-by: Ana <[email protected]>
zspencer
changed the title
zspencer
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #831
TODO
createaction work