Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Frame class #291

Merged
merged 20 commits into from
Dec 13, 2023
Merged

Implementation of Frame class #291

merged 20 commits into from
Dec 13, 2023

Conversation

PythonFZ
Copy link
Member

superseeds #283

@PythonFZ PythonFZ marked this pull request as ready for review December 13, 2023 09:23
@codecov-commenter
Copy link

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (bd605b9) 37.59% compared to head (b4a2f6e) 35.92%.

Files Patch % Lines
zndraw/frame.py 54.63% 44 Missing ⚠️
zndraw/zndraw.py 25.00% 15 Missing ⚠️
zndraw/utils.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
- Coverage   37.59%   35.92%   -1.67%     
==========================================
  Files          15       15              
  Lines        1298     1361      +63     
==========================================
+ Hits          488      489       +1     
- Misses        810      872      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PythonFZ PythonFZ merged commit 2c7dda6 into main Dec 13, 2023
3 checks passed
@PythonFZ PythonFZ deleted the frame_cls branch December 13, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants