Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add momenta to Frame #295

Conversation

PythonFZ
Copy link
Member

@PythonFZ PythonFZ commented Dec 13, 2023

  • tests

try to use zndraw file.xyz where the file has not only momenta but e.g. also forces.

@phohenberger phohenberger marked this pull request as ready for review December 15, 2023 12:32
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (49c00f1) 53.57% compared to head (b7d8984) 53.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
+ Coverage   53.57%   53.66%   +0.09%     
==========================================
  Files          17       17              
  Lines        1523     1526       +3     
==========================================
+ Hits          816      819       +3     
  Misses        707      707              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PythonFZ PythonFZ merged commit 4a2bb33 into main Dec 21, 2023
4 checks passed
@PythonFZ PythonFZ deleted the 294-typeerror-frame__init__-got-an-unexpected-keyword-argument-momenta branch December 21, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Frame.__init__() got an unexpected keyword argument 'momenta'
3 participants