-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Step Back and Restart feature #46
Conversation
This allows to jump back to the last frame or restart the visualization with a button. Name changes: Step: >> Step back: <<
Also added bugfix for number_of_steps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the PR. I do have one critical comment regarding getting the run time as for a static mesh object, this will be 1 which is then wrong for the other meshes. However, overall, really cool job.
If you can fix up the trajectory length (maybe use max instead of min) and make sure the tests are passing, I am happy to merge.
Adapted spacing as well
I ran the tests locally on my machine and it worked: platform linux -- Python 3.10.14, pytest-6.2.5, py-1.11.0, pluggy-1.4.0 CI/integration_tests/test_simple_spheres.py . [ 7%] ======================================================== 13 passed in 13.82s ========================================================= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the changes.
This allows to jump back to the last frame or restart the visualization with a control button.
changed title of step forward button to ">>" and called the Step back button "<<".
Sorted it like "<< Play >>" on a remote control.