Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql_flutter: remove old examples #1203

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

vincenzopalazzo
Copy link
Collaborator

I'm trying to my #1190 smaller and divided into different steps.

We start by removing the old example that is no longer meaningful because are old and some of them depend on a server that is no longer available!

Signed-off-by: Vincenzo Palazzo <[email protected]>

graphql_flutter: remove example from example dir

Signed-off-by: Vincenzo Palazzo <[email protected]>
@vincenzopalazzo vincenzopalazzo added the 🚄 doc & examples requests for documentation, usage examples, and support label Aug 21, 2022
@vincenzopalazzo vincenzopalazzo marked this pull request as ready for review August 21, 2022 15:58
Signed-off-by: Vincenzo Palazzo <[email protected]>
@budde377
Copy link
Collaborator

Removing the examples will negatively affect our pub score.

@vincenzopalazzo
Copy link
Collaborator Author

Removing the examples will negatively affect our pub score.

I see, but this example did not work anymore there is no reason to keep these inside the repo, and after the merging of the example proposed with other PRs, we should have the same scoring, but with functional example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚄 doc & examples requests for documentation, usage examples, and support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants