fix: response extensions should be optional #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1419 +/- ##
==========================================
+ Coverage 64.63% 64.83% +0.20%
==========================================
Files 41 41
Lines 1722 1732 +10
==========================================
+ Hits 1113 1123 +10
Misses 609 609 ☔ View full report in Codecov by Sentry. |
|
@vincenzopalazzo Hi, I've noticed that after merging #1394, tests were failing due to extensions being always present. Sorry for that, here is the fix for that. |
|
Hi @kamilkarp No problem :) my fault that I did not catch it during review, but can you fix the formatting of the code? |
|
@vincenzopalazzo Analyzer fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1394 made SubscriptionData json always containing extensions. Now extensions in json are only present if response contained them.