Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql): transform nested object from box #1421

Merged
merged 1 commit into from
Apr 13, 2024
Merged

fix(graphql): transform nested object from box #1421

merged 1 commit into from
Apr 13, 2024

Conversation

ronnnnn
Copy link
Contributor

@ronnnnn ronnnnn commented Apr 9, 2024

When the HiveStore is reopened and HiveStore#toMap is used, the following error occurs:

type '_Map<dynamic, dynamic>' is not a subtype of type 'Map<String, dynamic>?' in type cast

The related issue is #1091 and the pull request is #1167.
I believe HiveStore#toMap should also recursively transform nested objects.

@vincenzopalazzo vincenzopalazzo added this to the v5.2.0 milestone Apr 9, 2024
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to, pingin @budde377 just to see if he has any concern, if there is any response for a why ping me and we merge it

@vincenzopalazzo
Copy link
Collaborator

Ah in the meanwhile if it is possible add fix(graphql): inside the command line would be really good

@ronnnnn ronnnnn changed the title fix: transform nested object from box fix(graphql): transform nested object from box Apr 9, 2024
@ronnnnn
Copy link
Contributor Author

ronnnnn commented Apr 9, 2024

@vincenzopalazzo
Thank you, I added graphql scope with git commit --amend.

Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution :)

@vincenzopalazzo vincenzopalazzo merged commit 6b28b45 into zino-hofmann:main Apr 13, 2024
4 checks passed
@ronnnnn ronnnnn deleted the fix-hive-store-to-map branch April 13, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants