Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to restore CI #461

Merged
merged 4 commits into from
Sep 10, 2020
Merged

Try to restore CI #461

merged 4 commits into from
Sep 10, 2020

Conversation

davidstosik
Copy link
Contributor

@davidstosik davidstosik commented Feb 6, 2020

Just a quick attempt at getting green CI, after short conversation with @bf4 here: #458 (comment)

Cleanup Gemfile stuff

  • Untrack Gemfile.lock
  • Move inch gem from Gemfile to development dependency in gemspec

Details:
https://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/

Freeze development dependencies

Now Gemfile.lock is gone, the only thing governing which version of a gem to use in CI is the gemspec. First step was to lock the version of enough gems enough that bundle exec rake passes.

Next steps

Update dependencies

From here, anyone could look a the dependencies one by one and do the following work:

  • confirm whether that dependency is needed or not
  • if it is, try updating it
  • fix any code that breaks because of the update

For indirect dependencies, once their version constraint has been cleared, they should be removed from the gemspec file.

Depending on the versions of Ruby rspec_api_documentation wants to support, there might be more work (some gems drop support for older versions of Ruby, which means that depending on the local version of Ruby, one or another version of a gem could be needed).

Test in newer versions of Ruby

Then someone might want to introduce newer versions of Ruby on CI (in .travis.yml).

@davidstosik davidstosik changed the title Try to restore CI [WIP] Try to restore CI Feb 6, 2020
@davidstosik
Copy link
Contributor Author

image

Yass! 🎉

@davidstosik davidstosik changed the title [WIP] Try to restore CI Try to restore CI Feb 6, 2020
@bf4
Copy link
Contributor

bf4 commented Feb 6, 2020

@oestrich let's merge this!

And maybe give op commit?

@jakehow
Copy link
Member

jakehow commented Sep 10, 2020

@bf4 @davidstosik merging this.. sorry for the long delay. Open to thoughts around the future of project maintenance, see: #478

@jakehow jakehow merged commit a858252 into zipmark:master Sep 10, 2020
@davidstosik davidstosik deleted the CI-tests branch October 2, 2020 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants