Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update values.yaml - remove zitadel.configmapConfig.FirstInstance.MachineKeyPath #122

Closed
wants to merge 2 commits into from
Closed

Update values.yaml - remove zitadel.configmapConfig.FirstInstance.MachineKeyPath #122

wants to merge 2 commits into from

Conversation

jessebot
Copy link
Contributor

@jessebot jessebot commented Aug 17, 2023

Fixes error referenced here: #120

Alternatively, we'd need to remove the bit of code here to prevent this issue:

{{- if include "deepCheck" (dict "root" .Values "path" (splitList "." "zitadel.configmapConfig.FirstInstance.MachineKeyPath")) -}}
{{- fail "Specifying .Values.zitadel.configmapConfig.FirstInstance.MachineKeyPath is not supported" -}}
{{- end -}}

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

@fforootd
Copy link
Member

@eliobischof can you please have a look into this, thank you!

@jessebot thanks for the PR, you are great!

@eliobischof
Copy link
Member

Thank you. This and also test reliability is fixed in #111, though.
I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on .Values.zitadel.configmapConfig.FirstInstance.MachineKeyPath (still in values.yaml)
3 participants