feat: Add ability to specify initContainers #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czuares
force-pushed
the
feat/initContainers
branch
from
dc5d300 to
bc296db
Compare
|
CC @eliobischof |
czuares
force-pushed
the
feat/initContainers
branch
from
bc296db to
a65978c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definition of Ready
This piggybacks off #287 and extends the functionality to initContainers. This is an essential enhancement if you want to use a native Kubernetes Sidecar instead of an extra container. This allows Jobs to function as expected rather than hanging forever. The primary use case is deploying to Google's CloudSQL and allowing the init/setup jobs to work and exit properly.