Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: describe database user credentials handling #6283

Merged
merged 4 commits into from
Aug 2, 2023
Merged

docs: describe database user credentials handling #6283

merged 4 commits into from
Aug 2, 2023

Conversation

unique-dominik
Copy link
Contributor

  • Adds full helmfile + PostgreSQL example
  • Extends production checklist for bullet about insecure credentials
  • Extends database documentation to ensure secure user rotation

Refs: https://discord.com/channels/927474939156643850/927866013545025566/1133692721710772294

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@unique-dominik
feat: Add full example for helmfile + PostgreSQL
f58d09e 
- Adds full helmfile + PostgreSQL example
- Extends production checklist for bullet about insecure credentials
- Extends database documentation to ensure secure user rotation

Refs: https://discord.com/channels/927474939156643850/927866013545025566/1133692721710772294
@vercel
Copy link

vercel bot commented Jul 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2023 0:28am

@hifabienne hifabienne requested a review from eliobischof July 28, 2023 06:06
@hifabienne
Copy link
Member

@unique-dominik Thanks for your contribution.
@eliobischof can you have a look at it?

eliobischof
eliobischof reviewed Jul 28, 2023
View reviewed changes
Copy link
Member

@eliobischof eliobischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @unique-dominik, I like the docs improvements a lot 🙂 🙏

But I'd rather put the Helm example to the charts repo, like in this WIP and link them in the docs.

@unique-dominik
Copy link
Contributor Author

But I'd rather put the Helm example to the charts repo, like in this WIP and link them in the docs.

I yesterday had a gut feeling that this would be desired and would make more sense 🤣 Not a problem I move that there 👍 Give me this weekend 🤝

@unique-dominik unique-dominik mentioned this pull request Jul 28, 2023
Closed
11 tasks
@unique-dominik
Copy link
Contributor Author

Alright @eliobischof I moved the example over: zitadel/zitadel-charts#114
I see that your example folder is WIP so feel free to keep mine in WIP to. I created a new number folder so technically there would be no conflict. Or we rebase my PR onto your WIP branch also possible.

Thank you both for the nice IAM 🗼

@eliobischof eliobischof changed the title feat: Add full example for helmfile + PostgreSQL docs: describe database user credentials handling Jul 31, 2023
@eliobischof
Copy link
Member

Alright @eliobischof I moved the example over: zitadel/zitadel-charts#114 I see that your example folder is WIP so feel free to keep mine in WIP to. I created a new number folder so technically there would be no conflict. Or we rebase my PR onto your WIP branch also possible.

Thank you both for the nice IAM tokyo_tower

Looks good to me, thank you for the contribution 🙏 I'll have a look at the charts PR asap.

We'd like so send you a small gift in return. If you like that too, please send us a mail to [email protected]. You will get a link to a form for the details.

@eliobischof eliobischof enabled auto-merge (squash) July 31, 2023 08:20
@codecov
Copy link

codecov bot commented Jul 31, 2023 •
edited
Loading

Codecov Report

Merging #6283 (b457674) into main (cd5e176) will decrease coverage by 4.43%.
Report is 24 commits behind head on main.
The diff coverage is 34.46%.

@@            Coverage Diff             @@
##             main    #6283      +/-   ##
==========================================
- Coverage   49.95%   45.52%   -4.43%     
==========================================
  Files        1232      816     -416     
  Lines      110330    85246   -25084     
==========================================
- Hits        55110    38807   -16303     
+ Misses      52556    44637    -7919     
+ Partials     2664     1802     -862
Flag Coverage Δ
core-integration-tests-postgres ?
core-unit-tests 45.52% <34.46%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
internal/api/grpc/admin/iam_settings_converter.go 0.00% <0.00%> (ø)
internal/api/grpc/management/user.go 0.00% <0.00%> (ø)
internal/api/grpc/management/user_converter.go 0.00% <0.00%> (ø)
internal/api/oidc/client.go 0.00% <0.00%> (-22.31%) ⬇️
...pository/eventsourcing/eventstore/refresh_token.go 0.00% <0.00%> (ø)
.../auth/repository/eventsourcing/eventstore/token.go 0.00% <0.00%> (ø)
...l/auth/repository/eventsourcing/eventstore/user.go 0.00% <0.00%> (ø)
internal/command/instance.go 11.97% <0.00%> (-48.43%) ⬇️
internal/domain/factors.go 0.00% <ø> (-22.23%) ⬇️
internal/domain/secret_generator.go 0.00% <ø> (-100.00%) ⬇️
... and 11 more

... and 715 files with indirect coverage changes

@unique-dominik
Copy link
Contributor Author

We'd like so send you a small gift in return. If you like that too, please send us a mail to [email protected]. You will get a link to a form for the details.

You surprise me anew every week 🚀 ❤️ 🎁

@eliobischof eliobischof added the waiting For some reason, this issue will have to wait. This can be a feedback that is being waited for, a de label Aug 2, 2023
@eliobischof
Copy link
Member

eliobischof commented Aug 2, 2023 •
edited
Loading

I added the waiting label, as we need to fix a bug in the pipeline

@livio-a livio-a disabled auto-merge August 2, 2023 12:23
@livio-a livio-a merged commit 4e1dcc0 into zitadel:main Aug 2, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

🎉 This PR is included in version 2.32.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This PR is included in version 2.30.0-eventstore-performance.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

🎉 This PR is included in version 2.24.0-ignore-me.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

🎉 This PR is included in version 2.32.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.32.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliobischof eliobischof eliobischof approved these changes

Assignees
No one assigned
Labels
released on @merge-eventstore released on @next-rc released on @pipeline-upload-assets released on @2.32.x released waiting For some reason, this issue will have to wait. This can be a feedback that is being waited for, a de
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@unique-dominik @hifabienne @eliobischof @livio-a