Skip to content

Commit

Permalink
chore: minor fixes, remove unnecesary code
Browse files Browse the repository at this point in the history
  • Loading branch information
saleel committed Oct 17, 2023
1 parent 5bd21f3 commit 349472a
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 19 deletions.
34 changes: 17 additions & 17 deletions packages/contracts/src/EmailWalletCore.sol
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,22 @@ contract EmailWalletCore is EmailWalletEvents, ReentrancyGuard, OwnableUpgradeab
// Address of wallet implementation contract - used for deploying wallets for users via proxy
address public immutable walletImplementation;

// Max fee per gas in wei that relayer can set in a UserOp
uint256 public immutable maxFeePerGas;

// Time period until which a email is valid for EmailOp based on the timestamp of the email signature
uint256 public immutable emailValidityDuration;

// Gas required to claim unclaimed funds. User (their relayer) who register unclaimed funds
// need to lock this amount which is relesed to the relayer who claims it
uint256 public immutable unclaimedFundClaimGas;

// Gas required to claim unclaimed state
uint256 public immutable unclaimedStateClaimGas;

// Default expiry duration for unclaimed funds and states
uint256 public immutable unclaimsExpiryDuration;

// Mapping of relayer's wallet address to relayer config
mapping(address => RelayerConfig) public relayers;

Expand Down Expand Up @@ -97,22 +113,6 @@ contract EmailWalletCore is EmailWalletEvents, ReentrancyGuard, OwnableUpgradeab
// Mapping of emailAddrCommit to unclaimed state
mapping(bytes32 => UnclaimedState) public unclaimedStateOfEmailAddrCommit;

// Max fee per gas in wei that relayer can set in a UserOp
uint256 public immutable maxFeePerGas;

// Time period until which a email is valid for EmailOp based on the timestamp of the email signature
uint256 public immutable emailValidityDuration;

// Gas required to claim unclaimed funds. User (their relayer) who register unclaimed funds
// need to lock this amount which is relesed to the relayer who claims it
uint256 public immutable unclaimedFundClaimGas;

// Gas required to claim unclaimed state
uint256 public immutable unclaimedStateClaimGas;

// Default expiry duration for unclaimed funds and states
uint256 public immutable unclaimsExpiryDuration;

// Context of currently executing EmailOp - reset on every EmailOp
ExecutionContext internal currContext;

Expand Down Expand Up @@ -587,7 +587,7 @@ contract EmailWalletCore is EmailWalletEvents, ReentrancyGuard, OwnableUpgradeab
uint256 expiryTime,
uint256 announceCommitRandomness,
string memory announceEmailAddr
) public payable nonReentrant {
) public payable {
if (expiryTime == 0) {
expiryTime = block.timestamp + unclaimsExpiryDuration;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/contracts/src/interfaces/Types.sol
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ struct EmailOp {
uint256 timestamp; // Timestamp of the email
string maskedSubject; // Subject string with email address masked
string feeTokenName; // Name of the token to pay the fee
uint256 feePerGas; // Amount of ETH to be charged per gas
uint256 feePerGas; // Amount of wei to be charged per gas
bytes executeCallData; // data if the the command is "Execute"
address newWalletOwner; // Address of the new owner if the command is "Exit Email Wallet"
address newDkimRegistry; // Address of the new dkim registry if the command is "DKIM"
WalletParams walletParams; // Params when command = "Transfer" / "Send"
WalletParams walletParams; // Params when command = "Send"
ExtensionParams extensionParams; // Serialized params for the extension based on the template
ExtensionManagerParams extManagerParams; // Params when command = "Install Extension" / "Uninstall Extension"
bytes emailProof; // ZK Proof of Email receipt
Expand Down

0 comments on commit 349472a

Please sign in to comment.