Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/foundry zksync #21

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Feat/foundry zksync #21

wants to merge 18 commits into from

Conversation

wshino
Copy link
Contributor

@wshino wshino commented May 14, 2024 •
edited
Loading

  • fix create2
  • fix verifier
  • some test cases doesn't work correctly in my local due to missing libraries
  • fix deployment
  • merge main logic and zksync to unify the code with if statement
  • clean up
  • unit testing using foundry
  • unit testing using foundry-zksync(except for missing library issues)
  • update README.md
  • update integration testing
  • e2e testing with deployed into zksync sepolia

About number 3 issue the above, I've created the issue on foundry-zksync.
matter-labs/foundry-zksync#382

Related PR.
zkemail/wax#1

wshino added 16 commits May 14, 2024 16:56
@wshino wshino marked this pull request as ready for review May 18, 2024 09:11
@SoraSuegami
Copy link
Contributor

Thank you for your PR!
The third task/issue is finally solved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wshino @SoraSuegami