Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Added a Body masking Template #203

Merged
merged 6 commits into from
Aug 6, 2024
Merged

Conversation

shreyas-londhe
Copy link
Member

@shreyas-londhe shreyas-londhe commented Jul 13, 2024

Description

This PR includes adding a body masking template, which takes in the body and a mask and outputs a maskedBody revealing characters corresponding to the mask.

Example:

// INPUT
body: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
mask: [1, 0, 1, 0, 1, 0, 1, 0, 1, 0]

// OUTPUT
maskedBody: [1, 0, 3, 0, 5, 0, 7, 0, 9, 0]

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • I have discussed with the team prior to submitting this PR
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

Copy link
Member

@saleel saleel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Added some minor comments.

packages/circuits/helpers/body-masker.circom Outdated Show resolved Hide resolved
packages/circuits/helpers/body-masker.circom Outdated Show resolved Hide resolved
@Divide-By-0 Divide-By-0 merged commit 8685d35 into main Aug 6, 2024
5 checks passed
@shreyas-londhe shreyas-londhe deleted the feat/add-body-masking branch September 6, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants