-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
signing transaction with ethereumjs/tx #344
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and please resolve lint & integration test errors :)
@sifnoc I think it'll be good to add EIP1559 gas standard to the tx util |
Sure, as optional? or as default? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I think it is better to open new issue for supporting EIP-1559 typed transaction due to web3. The web3 version we using in zkopru currently not support also. So, we need to update web3 version then fully test with other packages. |
@sifnoc Hi Jin would u please resolv the conflict and merge this to the main branch? |
Sure! |
This PR no longer necessary if merge #381 |
web3.eth.account
For fixing #337