perf: improve performance of getSmallestEnclosure #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Though not on every tick, still a significant impact on MSPT.
Benchmark
Look up 1,000,000 random positions with enclosures data in our 1.21 server.
Code:
Result (10 tests each):
Changes
HashMap.values iterations is slow so used a list to cache the areas
Also removed the lockChecker for coordinates as it is not used. Possible reason: https://stackoverflow.com/questions/39152264/kotlin-how-can-i-avoid-autoboxing-garbage-in-delegated-properties but I can't fix the problem with the code in the link