Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better runCommand #28

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Conversation

wafarm
Copy link
Contributor

@wafarm wafarm commented Sep 4, 2023

Description/描述

A list based runCommand implementation.

Checklist/清单

  • My changes generate no new warnings/我的修改没有产生新的警告
  • My code builds and runs on my machine/我的代码在我的电脑上可以编译和运行
  • I documented my code/我已经为我的代码添加了注释/文档

Screenshots

image

Copy link
Collaborator

@Cubik65536 Cubik65536 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really the one who should review the code, but it looks great from a user point of view.

Except probably fix this:

image

and similar hover text missings.

Or we could wait till we hands directly on the i18n? @zly2006 (and some i18n related discussion in #29 )

@wafarm
Copy link
Contributor Author

wafarm commented Sep 5, 2023

Actually, it's a common issue with all masa mods using lists since the translation keys (or similar ones) didn't exist in the language files in malilib. If we are to fix this, then should we add the translation for the original malilib or just creating them in our own namespace (like reden.widget.hover.add) ?

@zly2006
Copy link
Owner

zly2006 commented Sep 5, 2023

I think we have no need to fix this translation issue because the icon is clear enough to let our users know what this button is used for.

I prefer to PR in malilib than use our own translation.

Copy link
Collaborator

@Cubik65536 Cubik65536 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, let's leave it like this for now, it's indeed better that the i18n issue can be fixed on malilib side.

Let's continue our own i18n related discussion in #29

@Cubik65536 Cubik65536 merged commit 7485380 into zly2006:1.20 Sep 5, 2023
2 checks passed
@wafarm wafarm deleted the better-command-hotkey branch September 5, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants