feat(shields): Add physical layouts for tester_xiao and tester_pro_micro #2852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! The commit history needs to be cleaned up, though. |
Added two layouts for the XIAO tester shield: - Keys arranged to match the XIAO pinout, viewed from the front - Single row of eleven keys These layouts are abstractions since the tester_xiao shield may be used in a situation where the "keys" are actually jumper wires on a breadboard or the like.
amacleod
force-pushed
the
tester-xiao-physical-layout
branch
from
7211835 to
a1fed8f
Compare
amacleod
added a commit
to amacleod/zmk-config
that referenced
this pull request
Mar 3, 2025
|
It would be good to have this for the Pro Micro shield too, would you be willing to add that as well? |
|
Sure! Same PR or separate?
…On Mon, Mar 3, 2025, 02:36 Cem Aksoylar ***@***.***> wrote:
It would be good to have this for the Pro Micro shield too, would you be
willing to add that as well?
—
Reply to this email directly, view it on GitHub
<#2852 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABM7G54GAP5BEZMTBBI73T2SQA7NAVCNFSM6AAAAABYF7B3WGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJTGUYTCNBRGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: caksoylar]*caksoylar* left a comment (zmkfirmware/zmk#2852)
<#2852 (comment)>
It would be good to have this for the Pro Micro shield too, would you be
willing to add that as well?
—
Reply to this email directly, view it on GitHub
<#2852 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABM7G54GAP5BEZMTBBI73T2SQA7NAVCNFSM6AAAAABYF7B3WGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJTGUYTCNBRGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I'd say same PR, different commits. |
amacleod
changed the title
amacleod
force-pushed
the
tester-xiao-physical-layout
branch
from
5a357f1 to
b69f107
Compare
|
Looks like I committed some trailing whitespace cruft. I will fix it as soon as I have a spare moment! |
amacleod
force-pushed
the
tester-xiao-physical-layout
branch
from
b69f107 to
a1de7c2
Compare
Nick-Munnich
approved these changes
Mar 6, 2025
caksoylar
reviewed
Mar 6, 2025
app/boards/shields/tester_pro_micro/tester_pro_micro-layouts.dtsi
Outdated
Show resolved
Hide resolved
amacleod
changed the title
amacleod
force-pushed
the
tester-xiao-physical-layout
branch
from
d5347f8 to
d4b96c6
Compare
Added two layouts for the Pro Micro tester shield: - Keys arranged to match the Pro Micro pinout, viewed from the front - Single row of eighteen keys
amacleod
force-pushed
the
tester-xiao-physical-layout
branch
from
d4b96c6 to
38aa008
Compare
caksoylar
approved these changes
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR check-list