Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all build, test, and install errors #21

Merged
merged 6 commits into from
Apr 26, 2024
Merged

Conversation

zmoog
Copy link
Owner

@zmoog zmoog commented Apr 26, 2024

Motivation

When running toggl-track on Python 3.10+ all tests using vcrpy fail, while they keep running on 3.7, 3.8 and 3.9.

The new default for vcrpy is to store the request body as a string, so I decided to rewrite the cassettes.

Change description

  • Replace all existing vcrpy cassettes with fresh data
  • Pin Pydantic to < 2 to avoid a breaking change in v2
  • Pin all other dependencies to avoid drift.

Additional Notes

Reviewer checklist

  • PR address a single concern.
  • PR title and description are appropriately filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • Docs are updated (at least the README.md, if needed).
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well-formatted.

When running toggl-track on Python 3.10+ all tests using vcrpy fail,
while they keep running on 3.8 and 3.9.

The new default for vcrpy is to store the request body as a string,
so I decided to rewrite the cassettes.
@zmoog zmoog self-assigned this Apr 26, 2024
@zmoog zmoog added the bug Something isn't working label Apr 26, 2024
@zmoog zmoog marked this pull request as ready for review April 26, 2024 05:40
@zmoog zmoog changed the title Rewrite vcrpy casettes Fix failing tests by rewriting vcrpy casettes Apr 26, 2024
@zmoog zmoog changed the title Fix failing tests by rewriting vcrpy casettes Fix failing tests on Python3.10+ by rewriting vcrpy casettes Apr 26, 2024
@zmoog zmoog merged commit 9cce38e into main Apr 26, 2024
5 checks passed
@zmoog zmoog deleted the zmoog/rewrite-vcrpy-cassettes branch April 26, 2024 05:43
@zmoog zmoog restored the zmoog/rewrite-vcrpy-cassettes branch April 27, 2024 05:05
@zmoog zmoog changed the title Fix failing tests on Python3.10+ by rewriting vcrpy casettes Fix all build, test, and install errors Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant