cleaned Code

znuny · Nov 28, 2023 · 1e78748 · 1e78748
1 parent a50e3a2
commit 1e78748
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/Kernel/System/Calendar/Appointment.pm b/Kernel/System/Calendar/Appointment.pm
@@ -2376,17 +2376,17 @@ sub _AppointmentRecurringCreate {
             my $EndDSTDiff = $EndTimeObject->CompareDST($OriginalEndTimeObject);
             my $CurrentStartTimeObject = $StartTimeObject->Clone();
             my $CurrentEndTimeObject   = $EndTimeObject->Clone();
-            if ( $StartDSTDiff ) {
-                if ( IsPositiveInteger($StartDSTDiff) ) {
+            if ( IsInteger( $StartDSTDiff ) ) {
+                if ( $StartDSTDiff > 0 ) {
                     $CurrentStartTimeObject->Subtract( Seconds => $StartDSTDiff );
                 }
                 elsif ( $StartDSTDiff < 0 ) {
                     $CurrentStartTimeObject->Add( Seconds => ($StartDSTDiff * -1));
                 }
                 $StartTime = $CurrentStartTimeObject->ToString();
             }
-            if ( $EndDSTDiff ) {
-                if ( IsPositiveInteger($EndDSTDiff) ) {
+            if ( IsInteger($EndDSTDiff) ) {
+                if ( $EndDSTDiff > 0 ) {
                     $CurrentEndTimeObject->Subtract( Seconds => $EndDSTDiff );
                 }
                 elsif ( $EndDSTDiff < 0 ) {

diff --git a/Kernel/System/DateTime.pm b/Kernel/System/DateTime.pm
@@ -2242,9 +2242,7 @@ sub _OpNotEquals {
 
 sub CompareDST {
     my ($Self, $OtherDateTimeObject) = @_;
-    my $TimeDif = $Self->{CPANDateTimeObject}->offset - $OtherDateTimeObject->{CPANDateTimeObject}->offset;
-
-    return $TimeDif;
+    return $Self->{CPANDateTimeObject}->offset - $OtherDateTimeObject->{CPANDateTimeObject}->offset;
 }
 1;