Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes missing docker login when using private registry #1217

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

djbelieny
Copy link

When using a private docker registry, docker commands in prepare-bundle and meteor-start scripts were not login into the private registry. Updated the code to receive the registry info from the config file and do the actual docker login when privateRegistry is set.

@zodern
Copy link
Owner

zodern commented Jan 7, 2021

Thanks @djbelieny for submitting this.

Mup should be logging into the registry during mup setup / mup docker setup, and docker should stay logged in. Does this not work for you?

@djbelieny
Copy link
Author

Hum... I don't remember doing a mup setup again since it was an app running in production that has been deployed for a long time (over a year), when mup did not suport private registry. We decided to upgrade the mup config and start sending the builds into a private registry to improve deployment times once it became available. The documentation did not mention that we would have to re-setup. Regardless we tried "everything" and it did not seem to login correctly until we modified the files in the PR.

@djbelieny
Copy link
Author

Oh. another thing, this is being used to deploy from a pipeline in Bitbucket building and putting the images into a DIgital Ocean container registry. I am not sure, but maybe the docker login happens in the pipeline vm which is volatile and only exists during the CI deployment, being deleted after each deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants