Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added graceful timeout in seconds #964

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SimonSimCity
Copy link

Added the option app.gracefulTimeout to decide many seconds a graceful shutdown is allowed to take - which is - how long docker should wait from calling docker stop (which triggers SIGINT) to calling docker rm -f (which triggers SIGTERM).

I don't know at which place the documentation can be updated, so I've left this task open.

The default value of app.gracefulTimeout is 10 and is in seconds.

As of how I see it, the other containers don't need a graceful shutdown, or do they? If yes, we need to take into account that e.g. nginx uses a different signal for a graceful shutdown than SIGINT - this just as a small note in case it's required.

This is untested though ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant