Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add targetPlatform field #20

Merged
merged 2 commits into from
Mar 30, 2024
Merged

feat: add targetPlatform field #20

merged 2 commits into from
Mar 30, 2024

Conversation

sylv256
Copy link
Contributor

@sylv256 sylv256 commented Jan 16, 2024

Fixes #19

@daiyam
Copy link
Member

daiyam commented Jan 16, 2024

Thanks for the PR.

But can you automatically detect the targetPlatform?

You can use import { platform, arch } from 'process'; then translate it to VSCode's TargetPlatform

export const enum TargetPlatform {
	WIN32_X64 = 'win32-x64',
	WIN32_ARM64 = 'win32-arm64',

	LINUX_X64 = 'linux-x64',
	LINUX_ARM64 = 'linux-arm64',
	LINUX_ARMHF = 'linux-armhf',

	ALPINE_X64 = 'alpine-x64',
	ALPINE_ARM64 = 'alpine-arm64',

	DARWIN_X64 = 'darwin-x64',
	DARWIN_ARM64 = 'darwin-arm64',

	WEB = 'web',

	UNIVERSAL = 'universal',
	UNKNOWN = 'unknown',
	UNDEFINED = 'undefined',
}

The platform and arch are the same as node's arch

@daiyam
Copy link
Member

daiyam commented Jan 21, 2024

@SylvKT Tell me if you can do the modifications. Thx

@sylv256
Copy link
Contributor Author

sylv256 commented Jan 22, 2024

Ah, sorry; I completely forgot about this PR. I'll fix it tomorrow probably.

@daiyam
Copy link
Member

daiyam commented Jan 22, 2024

No problem

@tomByrer
Copy link

@SylvKT ?

@daiyam daiyam merged commit fb17ad2 into zokugun:master Mar 30, 2024
@daiyam
Copy link
Member

daiyam commented Mar 30, 2024

The new version with the feature should be available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Platform Selection
3 participants