Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove traces of long-deprecated 'Shared' roles support #120

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Remove traces of long-deprecated 'Shared' roles support #120

merged 1 commit into from
Sep 19, 2024

Conversation

perrinjerome
Copy link
Contributor

This was removed in AccessControl since 3.0.7
see zopefoundation/AccessControl@9fb90b7e

@perrinjerome
Copy link
Contributor Author

I don't know what this was, but this is removed from AccessControl ( in zopefoundation/AccessControl@9fb90b7e ), and the base class no longer defines _shared_roles so I guess this branch was never executed.

@perrinjerome perrinjerome merged commit 681919f into master Sep 19, 2024
13 checks passed
@perrinjerome perrinjerome deleted the perrinjerome/remove-Shared-roles branch September 19, 2024 05:05
@perrinjerome
Copy link
Contributor Author

Thank you @dataflake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataflake dataflake dataflake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@perrinjerome @dataflake