Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all linters to pre-commit. #1164

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Move all linters to pre-commit. #1164

wants to merge 12 commits into from

Commits on Sep 21, 2023

  1. Move all linters to pre-commit.

    @sallner
    sallner committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    1cb817c View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci lite] apply automatic fixes

    @pre-commit-ci-lite
    pre-commit-ci-lite[bot] authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    afe29e3 View commit details
    Browse the repository at this point in the history

  3. Unfortunately a second run was needed.

    @sallner
    sallner committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    19cc6c1 View commit details
    Browse the repository at this point in the history

  4. Some doc strings need to have a value to be traversable. 

    This fixes some tests.
    @sallner
    sallner committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    6f609ac View commit details
    Browse the repository at this point in the history

  5. Add new linter teyit for deprecated assert statements.

    @sallner
    sallner committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    decedb0 View commit details
    Browse the repository at this point in the history

  6. [pre-commit.ci lite] apply automatic fixes

    @pre-commit-ci-lite
    pre-commit-ci-lite[bot] authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    50efcb0 View commit details
    Browse the repository at this point in the history

  7. Update pre-commit hooks.

    @sallner
    sallner committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    dcaf00b View commit details
    Browse the repository at this point in the history

  8. [pre-commit.ci lite] apply automatic fixes

    @pre-commit-ci-lite
    pre-commit-ci-lite[bot] authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    bfe6aa9 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Move slow linters back to tox -e lint. 

    Those checkers are not able to work on single files present in a commit but need conecptionally work on the whole repository (check-manifest) and thus are not suited to be run before each commit, but only in the CI.
    @sallner
    sallner committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    3743bf1 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    These are mostly documentation changes. Some of the docstrings might influence the public availability of the methods on an object.

Co-authored-by: Michael Howitz <[email protected]>
    @sallner
    sallner and Michael Howitz authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    e0f172c View commit details
    Browse the repository at this point in the history

  3. [pre-commit.ci lite] apply automatic fixes

    @pre-commit-ci-lite
    pre-commit-ci-lite[bot] authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    7415c00 View commit details
    Browse the repository at this point in the history

  4. Format line which was not touched by autopep8.

    @sallner
    sallner committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    3418f47 View commit details
    Browse the repository at this point in the history