Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash dev - test case fixes + signal OC4 patch #67

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

IgorTodorovskiIBM
Copy link
Collaborator

@IgorTodorovskiIBM IgorTodorovskiIBM commented Nov 22, 2023

Test fixes:

  • /etc/passwd does not exist on z/OS, add a condition to check for its presence
  • Change /etc/passwd to /etc/profile which exists on all platforms
  • Use grep -E instead of egrep to avoid "egrep is obsolete" message
  • Use /bin/test to check for /dev/stdin because bash emulates /dev/stdin and test builtin thinks it is present
  • Adds sig.c patch for Jenkins

Also, we wants the nodir version of /dev/fd to take precendence since all z/OS systems have it

I'll work with Chet from Bash to get these upstreamed.

Should bring down the number of failures to 15

Copy link
Collaborator

@MikeFultonDev MikeFultonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM

@IgorTodorovskiIBM IgorTodorovskiIBM merged commit 57d7010 into main Nov 22, 2023
1 check passed
@IgorTodorovskiIBM IgorTodorovskiIBM deleted the dev_improvements branch November 22, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants