Update Crossref REST translator #3359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To run test with Scaffold |
|
We should set Library Catalog to just "Crossref", not "Crossref REST". |
dstillman
reviewed
Sep 12, 2024
Crossref REST.js
Outdated
| } | ||
| // Add DOI to extra for unsupported items | ||
| else { | ||
| item.extra = (item.extra ? item.extra + '\n' : '') + 'DOI: ' + result.DOI; |
There was a problem hiding this comment.
We shouldn't need to do this manually. It should get set automatically if not valid for the type.
There was a problem hiding this comment.
(But that might not show up in tests.)
There was a problem hiding this comment.
Yes, it was exactly like that.
Fixed. However, I imagine it will be overridden, as is the case with the XML translator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed there are some differences in the available data compared to the XML API. For example, fields like ISBN, pages, editors, contributors, and language, etc. can sometimes be missing, but not always. However, this translator performs better with various book-related items.
It was tested with all item types provided by the Crossref API, and each item type is also included in the tests.
All in all, I think it's pretty good now.
The hyphen has been removed from the translator file name to match the actual translator name (there was an issue with Scaffold). I wonder if this could have any negative consequences?