Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new option to get the callNumber #3360

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

smachefert
Copy link
Contributor

After discussions on #3075 this PR should fix what has been said :

  • two tests have been removed in Primo 2018.js : one for a site that has disappeared (uqam), one for a page that automatic test in Scaffold can not handle properly;
  • a fix has been added to Primo normalized XML.js to get the information from a field that has been recently added to Primo and refactor the way xpath are treated. A test has been added to this translator to prove this is working fine, and a test has been updated that was previously missing the callnumber.

@AbeJellinek AbeJellinek merged commit 22fa76e into zotero:master Sep 26, 2024
1 check failed
@AbeJellinek
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants