-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for drag/drop of MVS files across LPAR'S #3413
Conversation
Signed-off-by: likhithanimma1 <[email protected]>
Signed-off-by: likhithanimma1 <[email protected]>
Signed-off-by: likhithanimma1 <[email protected]>
Signed-off-by: likhithanimma1 <[email protected]>
📅 Suggested merge-by date: 2/10/2025 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3413 +/- ##
==========================================
+ Coverage 93.20% 93.23% +0.03%
==========================================
Files 120 120
Lines 12583 12660 +77
Branches 2904 2875 -29
==========================================
+ Hits 11728 11804 +76
- Misses 854 855 +1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: likhithanimma1 <[email protected]>
Signed-off-by: likhithanimma1 <[email protected]>
packages/zowe-explorer/__tests__/__unit__/trees/dataset/DatasetTree.unit.test.ts
Fixed
Show fixed
Hide fixed
Signed-off-by: likhithanimma1 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this Likhitha! This looks great so far, but I have a request to minimize code duplication.
Signed-off-by: likhithanimma1 <[email protected]>
Signed-off-by: likhithanimma1 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for working on this new feature @likhithanimma1 this is really cool!
I believe the failing windows checks have a fix in the port 3.1.0 PR
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Not that this is a common scenario, but when dragging from LPAR1 to LAPR2, there could be some data-loss if they share the same DASD 😢
Can't really test via the CLI since there is no "Move" equivalent 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my feedback Likhitha - sorry I didn't catch this earlier, but I found a misspelled query parameter that needs adjusted. Aside from that, the code LGTM - the drag/drop works well and its very convenient!
Signed-off-by: likhithanimma1 <[email protected]>
d6718dd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks @likhithanimma1 for this feature!
Proposed changes
Implemented drag and drop functionality(move action) for the MVS files. Now user will be able to drag seq, pds and members from one LPAR and drop it on to another.
Release Notes
Milestone:
Changelog: Implemented drag and drop functionality of data sets within and across LPARs. [#3413]
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments