Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for drag/drop of MVS files across LPAR'S #3413

Merged
merged 17 commits into from
Feb 5, 2025

Conversation

likhithanimma1
Copy link
Contributor

@likhithanimma1 likhithanimma1 commented Jan 27, 2025

Proposed changes

Implemented drag and drop functionality(move action) for the MVS files. Now user will be able to drag seq, pds and members from one LPAR and drop it on to another.

Release Notes

Milestone:

Changelog: Implemented drag and drop functionality of data sets within and across LPARs. [#3413]

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

@likhithanimma1 likhithanimma1 marked this pull request as draft January 27, 2025 12:35
Copy link

github-actions bot commented Jan 27, 2025

📅 Suggested merge-by date: 2/10/2025

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 94.25287% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.23%. Comparing base (74f7815) to head (e042b97).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ages/zowe-explorer/src/trees/shared/SharedUtils.ts 78.57% 3 Missing ⚠️
...ges/zowe-explorer/src/trees/dataset/DatasetTree.ts 97.18% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3413      +/-   ##
==========================================
+ Coverage   93.20%   93.23%   +0.03%     
==========================================
  Files         120      120              
  Lines       12583    12660      +77     
  Branches     2904     2875      -29     
==========================================
+ Hits        11728    11804      +76     
- Misses        854      855       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: likhithanimma1 <[email protected]>
traeok
traeok previously requested changes Jan 28, 2025
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this Likhitha! This looks great so far, but I have a request to minimize code duplication.

anaxceron
anaxceron previously approved these changes Jan 28, 2025
Signed-off-by: likhithanimma1 <[email protected]>
@JillieBeanSim JillieBeanSim added this to the v3.2.0 milestone Jan 31, 2025
JillieBeanSim
JillieBeanSim previously approved these changes Jan 31, 2025
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for working on this new feature @likhithanimma1 this is really cool!

I believe the failing windows checks have a fix in the port 3.1.0 PR

zFernand0
zFernand0 previously approved these changes Feb 3, 2025
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

Not that this is a common scenario, but when dragging from LPAR1 to LAPR2, there could be some data-loss if they share the same DASD 😢

Can't really test via the CLI since there is no "Move" equivalent 😢

@traeok traeok dismissed their stale review February 3, 2025 20:11

Changes addressed, will review

traeok
traeok previously requested changes Feb 3, 2025
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my feedback Likhitha - sorry I didn't catch this earlier, but I found a misspelled query parameter that needs adjusted. Aside from that, the code LGTM - the drag/drop works well and its very convenient!

anaxceron
anaxceron previously approved these changes Feb 3, 2025
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@traeok traeok dismissed their stale review February 5, 2025 18:59

Changes addressed, will review

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @likhithanimma1 for this feature!

@JillieBeanSim JillieBeanSim merged commit eeeaf84 into main Feb 5, 2025
23 checks passed
@JillieBeanSim JillieBeanSim deleted the DragAndDropMvsFiles branch February 5, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

5 participants