Add ErrorHandling for OpenWithEncoding function

[likhithanimma1]

Proposed changes

Added try catch block for openWithEncoding function in order to catch any of the errors thrown.

Release Notes

Milestone:

Changelog:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds or improves functionality)
• Breaking change (a change that would cause existing functionality to not work as expected)
• Documentation (Markdown, README updates)
• Other (please specify above in "Proposed changes" section)

Checklist

General

• I have read the CONTRIBUTOR GUIDANCE wiki
• All PR dependencies have been merged and published (if applicable)
• A GIF or screenshot is included in the PR for visual changes
• The pre-publish command has been executed:
  • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
  • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

• There is coverage for the code that I have added
• I have added new test cases and they are passing
• I have manually tested the changes

Deployment

• I have added developer documentation (if applicable)
• Documentation should be added to Zowe Docs
  • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
  • Otherwise, please check with the rest of the squad about any needed documentation before merging.
• These changes may need ported to the appropriate branches (list here):

Further comments

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.24%. Comparing base (51d6ab4) to head (c91ec78).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #3438    +/-   ##
========================================
  Coverage   93.23%   93.24%            
========================================
  Files         120      120            
  Lines       12662    12664     +2     
  Branches     2922     2755   -167     
========================================
+ Hits        11806    11808     +2     
  Misses        855      855            
  Partials        1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📅 Suggested merge-by date: 2/20/2025

[zFernand0]

LGTM! 😋

I do not disagree with the changes, but I'm a bit curious how this can be properly tested. 😕
Right now, there is no way to use the Open With Encoding via the command palette since it doesn't work without a node. 🤔

I could be missing something but if credentials are invalid, I don't believe you will be able to get to the spoolfile to right click it and open it with a specific encoding.

That said, I still like the changes in preparation for when we make the openWithEncoding command work from the command palette 😋

[likhithanimma1]

LGTM! 😋

I do not disagree with the changes, but I'm a bit curious how this can be properly tested. 😕 Right now, there is no way to use the Open With Encoding via the command palette since it doesn't work without a node. 🤔

I could be missing something but if credentials are invalid, I don't believe you will be able to get to the spoolfile to right click it and open it with a specific encoding.

That said, I still like the changes in preparation for when we make the openWithEncoding command work from the command palette 😋

We have function fetchSpoolAtUri where we are using it inside the OpenWithEncoding function which may throw an error. So, tried to handle it with try catch.

[traeok]

LGTM, thanks @likhithanimma1