-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for extenders favorites not loading after registration #3482
Conversation
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3482 +/- ##
=======================================
Coverage 93.51% 93.52%
=======================================
Files 120 120
Lines 12694 12703 +9
Branches 2888 2891 +3
=======================================
+ Hits 11871 11880 +9
Misses 822 822
Partials 1 1 ☔ View full report in Codecov by Sentry. |
📅 Suggested merge-by date: 3/12/2025 |
Signed-off-by: Billie Simmons <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
It seems that we are not able to retrieve nested resources (PDS members and Spool files) on reload/opening of VSCode.
Is this a common issue?
Happens with z/SOMF and with FTP.
Thanks for looking into this Billie! I tried adding a data set node as a favorite for a
zftp
profile and that works as expected, but once I reload the window, there's an error loading the favorite:
I'm afraid I dind't run into this 😢
Thanks @zFernand0 & @traeok for testing. I was able to replicate the issue seen by Trea and is Windows specific. I will look into it 😄 |
Signed-off-by: Billie Simmons <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the recent change, I was able to add a PDS and a USS directory as a favorite. After reloading, both resources were in my favorites as expected. Thanks Billie for the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
* add fix for ds tree Signed-off-by: Billie Simmons <[email protected]> * add functionality for unix and jobs tree Signed-off-by: Billie Simmons <[email protected]> * revert changes made to test file Signed-off-by: Billie Simmons <[email protected]> * fix test Signed-off-by: Billie Simmons <[email protected]> * add CHANGELOG Signed-off-by: Billie Simmons <[email protected]> * ze api changelog Signed-off-by: Billie Simmons <[email protected]> * run prepublish Signed-off-by: Billie Simmons <[email protected]> * make some changes due to windows breakage Signed-off-by: Billie Simmons <[email protected]> --------- Signed-off-by: Billie Simmons <[email protected]>
* Fix for extenders favorites not loading after registration (#3482) * add fix for ds tree Signed-off-by: Billie Simmons <[email protected]> * add functionality for unix and jobs tree Signed-off-by: Billie Simmons <[email protected]> * revert changes made to test file Signed-off-by: Billie Simmons <[email protected]> * fix test Signed-off-by: Billie Simmons <[email protected]> * add CHANGELOG Signed-off-by: Billie Simmons <[email protected]> * ze api changelog Signed-off-by: Billie Simmons <[email protected]> * run prepublish Signed-off-by: Billie Simmons <[email protected]> * make some changes due to windows breakage Signed-off-by: Billie Simmons <[email protected]> --------- Signed-off-by: Billie Simmons <[email protected]> * Fix UNIX attributes refresh button (#3462) * early stage fixes Signed-off-by: Billie Simmons <[email protected]> * save state Signed-off-by: Billie Simmons <[email protected]> * set fetched values Signed-off-by: Billie Simmons <[email protected]> * run prepublish Signed-off-by: Billie Simmons <[email protected]> * add CHANGELOG Signed-off-by: Billie Simmons <[email protected]> * ZE API changelog Signed-off-by: Billie Simmons <[email protected]> * clean up of comments Signed-off-by: Billie Simmons <[email protected]> * add code cov Signed-off-by: Billie Simmons <[email protected]> * address comments and add coverage for updated checks Signed-off-by: Billie Simmons <[email protected]> * remove un-needed import Signed-off-by: Billie Simmons <[email protected]> * fix tests order info Signed-off-by: Billie Simmons <[email protected]> * make new api fetchAttributes optional Signed-off-by: Billie Simmons <[email protected]> --------- Signed-off-by: Billie Simmons <[email protected]> Signed-off-by: Billie Simmons <[email protected]> Co-authored-by: Trae Yelovich <[email protected]> Signed-off-by: Billie Simmons <[email protected]> --------- Signed-off-by: Billie Simmons <[email protected]> Signed-off-by: Billie Simmons <[email protected]> Co-authored-by: Trae Yelovich <[email protected]>
Proposed changes
package and install for testing
reuse initialization of favorites code for a new optional tree method refreshFavorites() that is now called after adding session to the tree
can use ftp to recreate and test fix
Release Notes
Milestone: 3.1.2 ?
Changelog:
ZE API - Added new optional
refreshFavorites
to IZoweTree interface. #3470ZE - Fixed an issue seen where extender favorites not showing in the tree views. #3470
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments