Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for extenders favorites not loading after registration #3482

Merged
merged 11 commits into from
Mar 3, 2025

Conversation

JillieBeanSim
Copy link
Contributor

@JillieBeanSim JillieBeanSim commented Feb 25, 2025

Proposed changes

package and install for testing

reuse initialization of favorites code for a new optional tree method refreshFavorites() that is now called after adding session to the tree

can use ftp to recreate and test fix

Release Notes

Milestone: 3.1.2 ?

Changelog:
ZE API - Added new optional refreshFavorites to IZoweTree interface. #3470
ZE - Fixed an issue seen where extender favorites not showing in the tree views. #3470

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

@JillieBeanSim JillieBeanSim self-assigned this Feb 25, 2025
@JillieBeanSim JillieBeanSim added this to the v3.1.2 milestone Feb 25, 2025
@JillieBeanSim JillieBeanSim linked an issue Feb 25, 2025 that may be closed by this pull request
Signed-off-by: Billie Simmons <[email protected]>
@pull-request-size pull-request-size bot added size/S and removed size/M labels Feb 25, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.52%. Comparing base (a05967b) to head (d98049e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3482   +/-   ##
=======================================
  Coverage   93.51%   93.52%           
=======================================
  Files         120      120           
  Lines       12694    12703    +9     
  Branches     2888     2891    +3     
=======================================
+ Hits        11871    11880    +9     
  Misses        822      822           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JillieBeanSim JillieBeanSim marked this pull request as ready for review February 26, 2025 22:41
Copy link

📅 Suggested merge-by date: 3/12/2025

Signed-off-by: Billie Simmons <[email protected]>
@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 26, 2025
traeok
traeok previously requested changes Feb 27, 2025
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this Billie! I tried adding a data set node as a favorite for a zftp profile and that works as expected, but once I reload the window, there's an error loading the favorite:

image

zFernand0
zFernand0 previously approved these changes Feb 27, 2025
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

It seems that we are not able to retrieve nested resources (PDS members and Spool files) on reload/opening of VSCode.

Is this a common issue?
Happens with z/SOMF and with FTP.
image


Thanks for looking into this Billie! I tried adding a data set node as a favorite for a zftp profile and that works as expected, but once I reload the window, there's an error loading the favorite:

image

I'm afraid I dind't run into this 😢

@JillieBeanSim
Copy link
Contributor Author

Thanks for looking into this Billie! I tried adding a data set node as a favorite for a zftp profile and that works as expected, but once I reload the window, there's an error loading the favorite:

image

Thanks @zFernand0 & @traeok for testing. I was able to replicate the issue seen by Trea and is Windows specific. I will look into it 😄

@traeok traeok dismissed their stale review March 3, 2025 15:30

request for changes addressed in d98049e

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the recent change, I was able to add a PDS and a USS directory as a favorite. After reloading, both resources were in my favorites as expected. Thanks Billie for the fix!

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@zFernand0 zFernand0 merged commit d7b66e0 into main Mar 3, 2025
25 checks passed
@zFernand0 zFernand0 deleted the fix/ext-faves branch March 3, 2025 19:05
JillieBeanSim added a commit that referenced this pull request Mar 4, 2025
* add fix for ds tree

Signed-off-by: Billie Simmons <[email protected]>

* add functionality for unix and jobs tree

Signed-off-by: Billie Simmons <[email protected]>

* revert changes made to test file

Signed-off-by: Billie Simmons <[email protected]>

* fix test

Signed-off-by: Billie Simmons <[email protected]>

* add CHANGELOG

Signed-off-by: Billie Simmons <[email protected]>

* ze api changelog

Signed-off-by: Billie Simmons <[email protected]>

* run prepublish

Signed-off-by: Billie Simmons <[email protected]>

* make some changes due to windows breakage

Signed-off-by: Billie Simmons <[email protected]>

---------

Signed-off-by: Billie Simmons <[email protected]>
zFernand0 pushed a commit that referenced this pull request Mar 6, 2025
* Fix for extenders favorites not loading after registration (#3482)

* add fix for ds tree

Signed-off-by: Billie Simmons <[email protected]>

* add functionality for unix and jobs tree

Signed-off-by: Billie Simmons <[email protected]>

* revert changes made to test file

Signed-off-by: Billie Simmons <[email protected]>

* fix test

Signed-off-by: Billie Simmons <[email protected]>

* add CHANGELOG

Signed-off-by: Billie Simmons <[email protected]>

* ze api changelog

Signed-off-by: Billie Simmons <[email protected]>

* run prepublish

Signed-off-by: Billie Simmons <[email protected]>

* make some changes due to windows breakage

Signed-off-by: Billie Simmons <[email protected]>

---------

Signed-off-by: Billie Simmons <[email protected]>

* Fix UNIX attributes refresh button (#3462)

* early stage fixes

Signed-off-by: Billie Simmons <[email protected]>

* save state

Signed-off-by: Billie Simmons <[email protected]>

* set fetched values

Signed-off-by: Billie Simmons <[email protected]>

* run prepublish

Signed-off-by: Billie Simmons <[email protected]>

* add CHANGELOG

Signed-off-by: Billie Simmons <[email protected]>

* ZE API changelog

Signed-off-by: Billie Simmons <[email protected]>

* clean up of comments

Signed-off-by: Billie Simmons <[email protected]>

* add code cov

Signed-off-by: Billie Simmons <[email protected]>

* address comments and add coverage for updated checks

Signed-off-by: Billie Simmons <[email protected]>

* remove un-needed import

Signed-off-by: Billie Simmons <[email protected]>

* fix tests order info

Signed-off-by: Billie Simmons <[email protected]>

* make new api fetchAttributes optional

Signed-off-by: Billie Simmons <[email protected]>

---------

Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>

---------

Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Extender type favorites not persisted
3 participants