-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewriting/editing ReadMe file #3484
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: anaxceron <[email protected]>
📅 Suggested merge-by date: 3/11/2025 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3484 +/- ##
========================================
Coverage 93.49% 93.49%
========================================
Files 120 120
Lines 12822 12822
Branches 2836 2943 +107
========================================
Hits 11988 11988
Misses 833 833
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for working on this @anaxceron left a couple comments on SSO & MFA scenarios
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me, thanks Ana for revamping our readme! I had a similar question to Billie regarding token login, but I agree with Adam's suggestion to adjust that part of the doc to mention how MFA could work for extenders.
Aside from that, 2 suggestions on conventions but nothing that needs to be changed.
Signed-off-by: anaxceron <[email protected]>
Sorry for the last-minute comments, I promise I'm done now 😅 |
Signed-off-by: anaxceron <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @anaxceron
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Thanks for addressing all the comments 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ana!
Hey @JillieBeanSim, 👋 I believe these requested changes have been addressed 🥳 |
Proposed changes
Editing/rewriting Readme to address Issue 3765
Release Notes
Milestone:
Changelog:
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments