chore(doc): update JavaScript example in README #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #450
Summary
Noticed that you were looking for someone to update the JavaScript example in the README so as our team as been using the
omniahth-google-oauth2gem for some time with a API only Rails app and it's been working fine for us since then I figured I might as well share our way of doing it.I removed the "Getting around the
redirect_uri_mismatcherror" section because I specify why theredirect_uri_mismatcherror might happen in my example and how to prevent it from happening.I also removed the
Using Axiosexample because imo showing an example with the native fetch API is the simplest example for a JS dev to understand and can easily be converted into any http request package that dev decides to use.