Added support for L*a*b* values being passed as Strings #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this library! I am working on a tool, that allows users to enter L*a*b* values in the browser. When passing the values directly from the input DOM elements, they are passed as Strings. This can cause some values to get concatenated instead of added together.
Example Code
Result
When a new
dE00
object is createdthis.LBar
,this.aPrime1
, andthis.aPrime2
will concatenate the two numbers in their respective formulas resulting in them being set toNaN
. This will causedE00.getDeltaE()
to also returnNaN
.Lines where concatenation occurs:
Fix: Apply
parseFloat()
to values ofx1
andx2